Make Jest dev-dependency?
SonyStone opened this issue · 3 comments
After update angular-playground it start using weak-napi, which using node-gyp, which using Python which makes Docker unhappy
Hi @SonyStone, we actually need jest for several of the core features of Playground, so it cannot be moved to the dev deps. You need to install Python in your docker image and then it should work.
Hi @timstoddard, thanks for quick answer.
Cannot angular-playground use those features directly, without need of jest?
Jest is pretty big dependency for "several" features. What are those features?
I see, that's jest only used with checkVisualRegressions which is off by default. So it's suppose to be a plugin or optional dependency. Why this this feature even here?
Yes, it is needed for the visual regression features. Many people requested the ability to test their sandbox scenarios for visual regressions, so we do not plan to make it an optional dependency. I know it can be frustrating when dependency authors add/change their dependencies, but that is out of our control as we do not develop Jest.
It looks like your error is actually caused by node-gyp, not Python. That error can be fixed by selecting the checkbox for "Automatically install the necessary tools" while installing NodeJS LTS version. I would recommend doing that on your Docker image as it should fix your problem.
