E_NOTICE in OAuth1:Twitter
arabcoders opened this issue · 2 comments
arabcoders commented
Hello,
There is an E_NOTICE in OAuth1:Twitter when User denies access.
(E_NOTICE) in (/vendor/socialconnect/auth/src/OAuth1/AbstractProvider.php:267) with message (Undefined index: oauth_verifier).
The fix might be as simple as
return $this->getAccessToken($token, $parameters['oauth_verifier'] ?? '');however i wanted to report the error first in case there is a problem with sending empty string to getAccessToken method.
arabcoders commented
i think we are not handling error in OAuth1 requests correctly.
it seems Twitter adds /?denied=token if user deines request. instead of usual /?token=token
arabcoders commented
no longer valid after pull request #115