SolidOS/contacts-pane

Present only affordances which are actually available

Opened this issue · 3 comments

I'm an unauthenticated user and I see the following:

image

As a general rule, an unauthenticated user should not be presented with controls that they can't eventually use; stick to the real affordances. In this particular case:

  • the icons to take a photo, upload an image, and delete should be removed.
  • the form fields should be replaced with plain text (if any currently filled)
  • additional controls like "Add one or more.." should be removed - basically the profile should only display as though the viewer is a reader (as opposed to writer/contributor).

The tooltip on the red trashcan is "Drag here to delete" - it is unclear what it is referring to but apparently it is about the image - figured this out after quick guessing and noting what a profile with a image looks like. This can be clarified with "Drag profile images here to delete".

When I try to drag the trashcan icon back into the trashcan:

image

While that may seem like a silly scenario to be in, the point is that the user should not be in that situation. Default to not exposing controls inapplicable to current user. Avoid introducing potential errors altogether.

timbl commented

image
It is improved in the sense of not prompting with tools to modify the data when don't have the authority to modify it.
It still presents blank fields which are not useful like

timbl commented

The test case above is https://csarven.inrupt.net/