SolidOS/solid-panes

Sharing Permissions not displayed

brownhoward opened this issue · 1 comments

In dev.inrupt.net, when navigating to the Sharing pane in the Data Browser, I do not see the Sharing permissions by group, just the Stop specific sharing for this folder button:
Image1

To Replicate

  1. Log into a Pod on server dev.inrupt.net.
  2. Navigate to a resource.
  3. Display the Sharing pane for the resource.

Expected

  1. The Sharing permissions for Owners, Editors, etc. are displayed.

Actual

  1. The Sharing permissions are not displayed.
  2. Error is seen in the Console:
http://www.w3.org/ns/auth/acl#Control
http://www.w3.org/ns/auth/acl#Read
http://www.w3.org/ns/auth/acl#Write' of undefined
    at b (acl-control.js:101)
    at acl-control.js:1128
    at acl.js:423
    at acl.js:453
    at fetcher.js:938
Vinnl commented

@timbl Looks like this commit is the issue: solid/solid-ui@5afb141, which was added by your request: https://github.com/solid/solid-ui/pull/123#pullrequestreview-291249392.

Specifically, byCombo appears to be referenced in quite a few locations still, and potentially box[defaultOrMain] as well. Although defaultOrMain would always have had the value 'main' before this commit, so I'm not sure what it's supposed to do. Could you clarify the required behaviour, and what code should be put back into place, if any?