Fix S2094 FP: Allow empty queries

Question

Closed this issue 3 months ago · 3 comments

It is not an uncommon pattern to have Querys with absolutely no members in it when using CQRS design pattern.
In such cases, rule S2094 raises.

Consider the following class, which is a totally valid Query.

public class GetAllUsersQuery {}

I would expect rule S2094 not to raise on such classes.

I would suggest ignoring classes that have known Query suffix

Answer 1 · 2024-05-02T13:10:30.000Z

Expands #9063

Answer 2 · 2024-05-03T14:04:00.000Z

Hi @fraserkyle, thanks for the report!
I confirm this as an FP.

Answer 3 · 2024-05-03T14:04:24.000Z

This will require an RSPEC update.