Fix S4158 FP: collection filled by another function

[CristianAmbrosini]

Source: https://community.sonarsource.com/t/false-positive-for-s4158/117480

S4158 is incorrectly raised when a list is filled by another function and then iterated:

class CollectionFilledByAnotherFunction
{
  List<int> Numbers { get; set; }

  void Initialize()
  {
    Numbers = new List<int>();
    InitializeNumbers();
    foreach (var number in Numbers) // Noncompliant FP
    {
      System.Console.WriteLine(number);
    }
  }

  void InitializeNumbers()
  {
    Numbers.Add(1);
    Numbers.Add(2);
    Numbers.Add(3);
  }
}

[Tim-Pohlmann]

The cause of the problem is that the invocation processor is only resetting field states. Properties are missing from the logic:

sonar-dotnet/analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.cs

Lines 48 to 51 in f563cae

	if (invocation.HasThisReceiver(state))
	{
	state = state.ResetFieldConstraints();
	}