Homework improvements
Opened this issue · 0 comments
hynesy23 commented
HTML
Line 7 in 695ae04
Big chunk of commented code, best just to delete if unneeded.
Line 62 in 695ae04
Not really any need to give an element the same id and class name, one or the other would do, and you can style and target an element in JS with either an ID or a class
SCRIPT
coding_quiz/assets/js/script.js
Line 157 in 695ae04
Rather than have an else if here, on line 154 you could just check if timeLeft is >= (greater or equal to) 1 (as both blocks do the same thing)
coding_quiz/assets/js/script.js
Line 175 in 695ae04
No need for this function. You are returning highscore but you are not actually doing anything with that returned value
coding_quiz/assets/js/script.js
Line 202 in 695ae04
This link is broken. You are backing up to far with the '../../', I think all you need here is just './highscores'
HIGHSCORES
coding_quiz/assets/js/highscores.js
Line 65 in 695ae04
Really tiny point but you can just do this in your noHighScores func as this is responsible for setting the content of highScoresContainer. Remember ideally you want a function to concentrate on just doing one job