Error decoding ein.Domain object: json: cannot unmarshal number into Go struct field Trust.Trusts.TrustDirection of type string

[AdrianVollmer]

Description:

I tried to upload data collected with SharpHound 2.3.3. The UI showed no error, but no data was available. All object counts under "Data Quality" were zero. I'm on 5.8.0.

On the command line I saw this error:

{"level":"error","time":"2024-04-15T12:01:25.879405402Z","message":"Error decoding ein.Domain object: json: cannot unmarshal number into Go struct field Trust.Trusts.TrustDirection of type string"}

I tracked it down to the trust object:

$ diff <(cat 20240415120236_domains.json| jq .) <(cat 20240415120236_domains_FIXED.json |jq . )
5836,5845c5836
<       "Trusts": [
<         {
<           "TargetDomainSid": "S-1-5-21-6275280071-1725281274-833003630",
<           "TargetDomainName": "ACME.ORG",
<           "IsTransitive": true,
<           "SidFilteringEnabled": false,
<           "TrustDirection": 3,
<           "TrustType": 2
<         }
<       ],
---
>       "Trusts": [],

(SID and Domain have been altered for privacy)

The second file, where I manually deleted the trust objects, was ingested just fine and objects appeared.

Component(s) Affected:

• UI
• API
• Neo4j
• PostgreSQL
• Data Collector (SharpHound, AzureHound)
• Other (tooling, documentation, etc.)

Steps to Reproduce:

I guess: get some data, replace the Trusts property with what you see above, and upload the data.

Expected Behavior:

The data to show up. Or at least get a meaningful error from the UI.

Actual Behavior:

Data does not show up. Object counts are zero.

Screenshots/Code Snippets/Sample Files:

If applicable, add screenshots, relevant code snippets, or sample files that help illustrate the issue.

Environment Information:

BloodHound: 5.8.0 docker image

Collector: SharpHound 2.3.3

OS: Debian

Browser (if UI related): [browser name and version]

Node.js (if UI related: [Node.js version]

Go (if API related): [Go version]

Database (if persistence related): [Neo4j version / PostgreSQL version]

Docker (if using Docker): [docker version]

Contributor Checklist:

• I have searched the issue tracker to ensure this bug hasn't been reported before or is not already being addressed.
• I have provided clear steps to reproduce the issue.
• I have included relevant environment information details.
• I have attached necessary supporting documents.
• I have checked that any JSON files I am attempting to upload to BloodHound are valid.