Does get_data have annotations?
Closed this issue · 4 comments
On Population.get_data, there's an additional annotations parameter (relative to PopulationBase. Should this also be on the base class and on PopulationView? Or is this something where the population just fundamentally varies from the views over it? (That would be odd for PyNN…)
(Found as part of #287.)
Looking at:
http://neuralensemble.org/docs/PyNN/reference/populations.html
It is UGLY!!!!!
Populations.get_data(variables='all', gather=True, clear=False)
Views.get_data(variables='all', gather=True, clear=False)
BUT!
Assemblies.get_data(variables='all', gather=True, clear=False, annotations=None)
All write_data(io, variables='all', gather=True, clear=False, annotations=None)
PyNN has a different way of getting data for write_data vs get_data.
We have the same method!
So We will just have annotations on all methods that provide data!
Also is it very easy to annotated an neo object so why not let the isers do that?
Addressed in #291
No idea WHY users would want to add WHAT annotations but as we know how to let them why not.
fixed as much as PyNN allows