Spice-King/foundry-swnr

Incompatible with Tokenizer module

Closed this issue · 0 comments

Version
Foundry Version: 0.7.9
Module Version: 0.4.0 Prerelease

Expected Behavior
When using the Tokenizer module (v2.2.8), clicking the character portrait should open up the token editor instead of the default file upload dialog.

Actual Behavior
When I click the character portrait, the default file upload window appears.

Additional Info
Granted, it's not necessarily top priority to maintain compatibility with every single module in the universe. That said, it appears that the fix for this may be relatively simple. It appears that Tokenizer looks for profile images with one of a number of different CSS classes as seen here in order to hook the profile picture change event. If that's all that needs to change, then either this system needs to change the profile-image CSS class to match something that Tokenizer is looking for (e.g. profile-img) or Tokenizer needs to be updated to include profile-image in its list of detectable profile image classes.

Given that Tokenizer is ostensibly written to be compatible with "most used game systems", it may be reasonable to treat their list of CSS classes as sort of a standard-by-fiat, such that any system that wants to be compatible with the module should implement one of those features. A quick perusal of the SWNR system code base suggests that changing the name of these classes would have no detrimental effects, as it does not appear that these CSS classes are addressed anywhere outside their definition.

That said, it's also reasonable that augmenting this list in Tokenizer is another route to fixing this, and arguably more appropriate. I could see it happening either way.