Spiderpig86/Cirrus

Adding `modal-large` to modal didn't work

zemian opened this issue · 4 comments

zemian commented

I tried it here: https://codepen.io/zemian/pen/OJrMNPe and it has no affect. Did I do something wrong?

Spiderpig86 commented

For modals, the modal-large and modal-small classes only affect the max-width of the modal, not width itself. If you want to set the width, consider using the width utility classes. https://www.cirrus-ui.com/layout/width#width

zemian commented

Then I failed to see the purpose (usefulness) of modal-large class.

Also, the docs says add modal-large to modal, but if I were to use the utility class such as w-80p, I have to add to modal-content in order to work.

This is just too much guess work for a user to simply want a larger dialog box. Can this be improved?

Spiderpig86 commented

This will have to be re-done in terms of naming, but that would be a breaking change. I agree that it is confusing since modal encompasses everything (the dialog itself and the background shadow) while modal-content is the dialog itself. Ideally, these should be renamed as modal-container and modal respectively.

I will make a decision to see if there is quite a big risk for this breaking change.

  • 👍1