Splamy/ScoreSaberEnhanced

Issue that when add user to cache

354316936 opened this issue · 2 comments

image
image

Adding some users to the cache sometimes fails, the number of empty pages cannot be read.

I'm experiencing this issue too, I suspect its when the final page has the maximum number of scores in pagination (i.e. 8 scores), so there's no new page to get. The responsible code is likely here:

was_last_page: recent_songs.scores.length < 8

I think an additional check should be added when fetching a score page for a 404 status code, stopping pagination and assuming it's the end of the results.

I created a PR to fix this: #23