SpongePowered/math

Use flooring when converting from float to int, instead of truncation

Closed this issue · 3 comments

DDoS commented

Truncation leads to issues when dealing with negative numbers.

What issues?
Also, are you sure we want to floor towards -inf, not towards zero?

DDoS commented

Flooring is the correct behaviour and we need this for Sponge.

On Aug 12, 2015, at 2:07 AM, Wolf480pl notifications@github.com wrote:

What issues?
Also, are you sure we want to floor towards -inf, not towards zero?


Reply to this email directly or view it on GitHub.

DDoS commented

Fixed in commit b13d73a.