StackStorm/st2-dockerfiles

Improve error handling in the Makefile

winem opened this issue · 0 comments

winem commented

Depending on "Error" message as a failure indicator adds some knowledge overhead in requirements that could be broken in the future. What if 3rd Maintainer comes, edit the determine_needed_tags.sh script and doesn't add "Error" message for the failure case.

We can at least reinforce it with determine_needed_tags.sh || echo Error to fit your solution.

The comment above was originally posted by @armab in #41 (comment) and he actually has good point there. The current solution requires some extra knowledge and might confuse maintainers.