Reservation Acquire Poisoning

Question

Reservation Acquire Poisoning

lightsighter opened this issue a year ago · 6 comments

There are calls to has_triggered in the Realm reservation acquisition code that don't handle poison correctly. An example backtrace is the following:

[4] = /leonardo/home/userexternal/mdirenzo/htr/bin/prometeo.exec(Realm::Event::has_triggered() const+0x118) [0x3d681a8]
[5] = /leonardo/home/userexternal/mdirenzo/htr/bin/prometeo.exec(Realm::Reservation::acquire(unsigned int, bool, Realm::Event) const+0x27) [0x3df5507]

Originally reported by @mariodr. Also adding @apryakhin since I think he volunteered to help with this one.

Answer 1 · 2023-12-11T08:04:02.000Z

@elliottslaughter, can you add this issue to #1032?

Answer 2 · 2023-12-11T10:47:16.000Z

I will be looking at this shortly today

Answer 3 · 2023-12-15T10:32:53.000Z

I will be submitting the patch to fix this for review today

Answer 4 · 2024-01-01T15:51:51.000Z

The patch has been merged

Answer 5 · 2024-01-01T23:32:56.000Z

Assigning back to @mariodirenzo to confirm. I upstreamed it to control replication.

Answer 6 · 2024-01-02T09:19:51.000Z

I can't reproduce the bug anymore. Thanks for fixing the issue