floating pane doesn't show up
Morganwan90 opened this issue · 39 comments
version 1.4.1
the floating pane doesn't show up when right click
Same here, incredibly useful add-in otherwise. I think it went with Obsidian v 1.4.2
same here
1.4.5 same here
1.4.5 the same error 😂
1.4.5 the same error...
I am using Table Enhancer v0.5.10 & Obsidian v1.4.5 with the same problem
what's going on? the problem is I cannot find
A: Make sure "Settings - Appearance - Native menus" is DISABLED!
+1
+1
+1
+1
1.4.5 +1
god please
1.4.12 +1
1.4.12 +1
could someone fix this?
version: 1.4.14
same problem
+1
could someone fix this?
@avraam-inside test with #98
@Stardusten please review #98
请问可以提供编译后的js代码段吗？
这段js代码无效
this.registerEvent(this.app.workspace.on("layout-change", function () {
const view = this.app.workspace.getActiveViewOfType(MarkdownView).contentEl;
view.querySelectorAll("div.cm-embed-block.cm-table-widget").forEach(function (el) {
el.attributes.getNamedItem("contenteditable").value = "true";
});
}));I tried both code block options - it doesn't work(
@zhaihao - I stuck your piece of code into compiled "main.js" file of the plugin - but the plugin simply does not start because of the line "view: HTMLElement". Without it - plugin runs, but doesn't work.
@YzZZZZZZZZZZZ Your option runs the plugin, but contenteditable is still "false"
It is not possible to get into this event through debugger - do you have any ideas why it does not work when the plugin is launched?
I tried both code block options - it doesn't work(
@zhaihao - I stuck your piece of code into compiled "main.js" file of the plugin - but the plugin simply does not start because of the line "view: HTMLElement". Without it - plugin runs, but doesn't work.
@YzZZZZZZZZZZZ Your option runs the plugin, but contenteditable is still "false"
ignore ts compile error
// @ts-ignore
I could help out with running tests on the new code to see if it works or not. let me know.
Fixed in the latest release https://github.com/Stardusten/ob-table-enhancer/releases/tag/0.5.11. Big thanks to @zhaihao
Yes, but what have you released?) We have been in correspondence here above - no solution has been found, and the proposed ones do not work. I downloaded the release - still hanging contenteditable = false
☝️ Can confirm this on my side. Having the same problem.
☝️ Can confirm this on my side. Having the same problem.
Yes, but what have you released?) We have been in correspondence here above - no solution has been found, and the proposed ones do not work. I downloaded the release - still hanging contenteditable = false
My bad. My current workaround doesn't work all the time. I still need some time to figure out how to fix it.
@Stardusten
No worries. Take your time. The problem is a challenge to overcome. Again, let me know when your fix is ready for testing so I can test it on my side.
☝️ Can confirm this on my side. Having the same problem.
@Stardusten
Yes, but what have you released?) We have been in correspondence here above - no solution has been found, and the proposed ones do not work. I downloaded the release - still hanging contenteditable = false
My bad. My current workaround doesn't work all the time. I still need some time to figure out how to fix it.
@Stardusten
"layout-change" event only works when we change from reading view to living view. So, if we click the "edit this block" button, the DOM will be re-rendered, and contenteditable will be set to false again. I can't find any API for this event.
The "editor-change" event maybe work well but has poor performance.
☝️ Can confirm this on my side. Having the same problem.
@Stardusten
Yes, but what have you released?) We have been in correspondence here above - no solution has been found, and the proposed ones do not work. I downloaded the release - still hanging contenteditable = false
My bad. My current workaround doesn't work all the time. I still need some time to figure out how to fix it.
@Stardusten "layout-change" event only works when we change from reading view to living view. So, if we click the "edit this block" button, the DOM will be re-rendered, and contenteditable will be set to false again. I can't find any API for this event. The "editor-change" event maybe work well but has poor performance.
I think pop out a menu when click a table cell would be better. But that may take some times.
The official team is already working on a table editor, so I'm not sure if it's worth investing too much time into this.
The official team is already working on a table editor, so I'm not sure if it's worth investing too much time into this.
@Stardusten
Is the official name "Table Editor" or a different name? I would like to try it out to provide feedback if I can be of any help.
If there is a better alternative table plugin than this, then you can give up on this plugin. I hope it will be a better one than this plugin.
The official team is already working on a table editor, so I'm not sure if it's worth investing too much time into this.
On the one hand, yes, they work, on the other, I know 4+ plugins for working with tables with different implementations, and yours is the best) What core-team will do still needs to be seen))) And they have a lot of tasks)
If it's not difficult, I would like to fix contenteditable. If it's difficult, it's probably worth looking at the creation of the core team first
In fact, I have found that this plugin always affects the two typewriter mode plugins. Every time I want to use the typewriter mode plugin, I need to turn off this plugin. I wonder if this discovery would be helpful to the author?
In fact, I have found that this plugin always affects the two typewriter mode plugins. Every time I want to use the typewriter mode plugin, I need to turn off this plugin. I wonder if this discovery would be helpful to the author?
hey everyone! i think i found a temporary fix. if you "crtl + e" twice, and then try to right click, the pane should show up. You will need to do this every time you use a function in the pane. this seems to be the best way to get it to pop up imo. not sure if there is a token in this temporary solution.
hey everyone! i think i found a temporary fix. if you "crtl + e" twice, and then try to right click, the pane should show up. You will need to do this every time you use a function in the pane. this seems to be the best way to get it to pop up imo. not sure if there is a token in this temporary solution.
note: i found your cursor also needs to be on a blank line. thanks!
hey everyone! i think i found a temporary fix. if you "crtl + e" twice, and then try to right click, the pane should show up. You will need to do this every time you use a function in the pane. this seems to be the best way to get it to pop up imo. not sure if there is a token in this temporary solution.
note: i found your cursor also needs to be on a blank line. thanks!
obsidian version: v1.4.16
plugin version: latest
I tried this but failed. I moved my cursor in different positions, but it just do not show up. I guass it is because some other plugins affect its function.
Seems obsidian 1.5.0 has most of this functionality now built in. Still preferred this one though