Starfield-Reverse-Engineering/commonlibsf-xrepo

PLUGIN_EMAIL not used? Should it be removed as an option to the rule?

Closed this issue · 4 comments

FlayaN commented

PLUGIN_EMAIL = configs.email or "",

qudix commented

I just left it in for future potential use. It doesn't really cost anything to leave it as is.

FlayaN commented

Ah ok, just thought it would be clearer to not have unused stuff. People might be curious why you should pass in email. Minimize the stuff they have to look up, maybe remove from the example project at least until it's used then?

qudix commented

Well if I remove it people are unlikely to populate it, which means if it gets used in the future their plugins wont contribute that info automatically.

FlayaN commented

Ah gotcha