StatCan/jupyter-apis

UI fix: Friendly add an existing volume

wg102 opened this issue · 2 comments

wg102 commented

This was found while testing the pipelines. It would be a UI enhancement.

The idea would be to make it more intuitive, most likely by having a label/text and not a dropdown in the menu of type. At least in this case... It induces the user in error.

ORIGINAL MESSAGE:
I am not sure if this is supposed to be like this, but the only option is to add a New volume. No existing.
The "Attach an existing volume" is grayed out.
image

Addendum:
I think this is actually related to how the UI works. The type, despite being a DROPDOWN. Is just showing the default empty volume created.
image
One needs to delete the default workspace create to be able to attach the volume directly.
image

Looking into it, the volume type is not being used in the data sent to the backend when creating a new notebook.
image

So we can safely just remove this field, and it can easily determined what type of volume is currently being added in the line right above the type input (it will show either "New Volume or "Existing Volume")

New volume:
image

existing volume:
image