StatCan/jupyter-apis

Visual bug with image selection in new notebook form

mathis-marcotte opened this issue · 1 comments

When chosing an image for a new notebook, you have to click on the actual text or icon of the image button for it to work, which doesn't behave too well when the image button doesn't have much text(see picture).
image

It would probably be better to have the whole image button be clickable instead of just where the text is, mainly to avoid confusion from the users where they could be clicking on what looks like a button and it not responding.

The issue was that the button element inside those server image button elements were not taking the entire space of the button group.
image

So I just bumped up the height to 100% for the button element and the span inside that button.

Now, they are taking the entire button space.
image