StefH/WebDAV-Client

Add support for using a custom HttpClient or HttpMessageHandler

fubar-coder opened this issue · 12 comments

fubar-coder commented

It would be useful when you would be able to provide a custom HttpClient or HttpMessageHandler. This would allow the usage of the client in the following scenarios:

  • Test for ASP.NET Core using the TestHost (with custom HttpMessageHandler or HttpClient)
  • Usage on Android and iOS (with custom HttpMessageHandler)
StefH commented

Adding a custom HttpClient is possible. Do you also need another option to provide a custom HttpMessageHandler?

fubar-coder commented

Having both options would be nice, but I'd prefer the ability to use a custom HttpMessageHandler, because that would allow the usage of implementations like NativeMessageHandler from Paul Betts.

StefH commented

I did update the constructors, please take a look if this is fine for you. (See latest code in this github project)

fubar-coder commented

Seems to be what I was looking for 👍 .

Just one thing, can you please add an additional net46 target which uses the System.Net.Http nuget package instead of the framework assemblies? I guess that System.Net.Http contains a bug fix for net46, because it supplies its own assembly (but uses the framework assemblies for net45).

StefH commented

You want the 4.3.0 versipn I guess? And only for 4.6 ?

fubar-coder commented

I think that a lower version might be fine. You can always upgrade yourself, but a downgrade gets difficult.

StefH commented

For now I just used 4.3.0

See NuGet from this feed:
https://www.myget.org/F/webdav-client/api/v3/index.json

If this one works fine; I will upload to real NuGet

fubar-coder commented

Works fine with my ASP.NET Core test project

StefH commented

Can you also chexk for a 462 project?

fubar-coder commented

Sure, but not today anymore.

fubar-coder commented

Running tests in a net462 project works too.

StefH commented

Uploaded to NuGet.org