StefH/angular-odata-es5

toCommaString break Datetime comparator

bastienlemaitre opened this issue · 6 comments

bastienlemaitre commented

Hi
The toCommaString present into this file : 'angular-odata-es5/src/angularODataOperation.ts' seems to broke the Datetime comparator.
For example:
SignatoryID eq ${this.signatory.ID} and EndDate lt ${new Date().toISOString()}
Format -> SignatoryID eq 14 and EndDate ge 2018-02-07T09:58:30.897Z
toCommaString -> SignatoryID eq 14 and EndDate ge 2018-02-07T09:58:30/897Z
The dot is replaced by a slash..

bastienlemaitre commented

Maybe add a regex to handle ISODatetime ?

StefH commented

OK. This has to be fixed.

  • 👍2
bastienlemaitre commented

Does we really need toCommaString ?

StefH commented

No, I have to rewrite the code. I keep you updated on progress...

bastienlemaitre commented

Thanks !

StefH commented

Fixed.
See new NPM : 0.2.10