StepfenShawn/Cantonese

`six` package dependency error

dosentmatter opened this issue · 2 comments

Hello, after installing Cantonese, it fails to run because of the import six that isn't included in your list of dependencies.

import six

Cantonese/setup.cfg

Lines 31 to 34 in 4870538

install_requires=
setuptools >= 0.7.0
pygame >= 1.9.4
Kivy >= 2.0.0

You only support Python 3 in setup.cfg and the README, so it doesn't look like you would need six for Python 2 interoperability.

python_requires = >=3.6

It doesn't seem like you are using six at all. Can we delete the import six line?

% Cantonese
Traceback (most recent call last):
  File "/Users/dosentmatter/.pyenv/versions/3.9.6/bin/Cantonese", line 5, in <module>
    from src.cantonese import main
  File "/Users/dosentmatter/.pyenv/versions/3.9.6/lib/python3.9/site-packages/src/cantonese.py", line 12, in <module>
    from src.stack_vm import *
  File "/Users/dosentmatter/.pyenv/versions/3.9.6/lib/python3.9/site-packages/src/stack_vm.py", line 9, in <module>
    import six
ModuleNotFoundError: No module named 'six'

The workaround is to pip install six, but this shouldn't be necessary.

OK, I will delete it in the next version.

Thanks for the fix @StepfenShawn.

Deleted in this commit