Stericson/RootShell

seems no implement of `RootShell.getCustomShell`

yurenchen000 opened this issue · 6 comments

https://github.com/Stericson/RootShell/search?utf8=✓&q=getCustomShell&type=

only this Recursive Call:

public static Shell getCustomShell(String shellPath, int timeout) throws IOException, TimeoutException, RootDeniedException
{
    return RootShell.getCustomShell(shellPath, timeout);
}

I'm sure you figured it out by now, but for completeness, it's supposed to be

return Shell.startCustomShell(shellPath, timeout);

instead of

return RootShell.getCustomShell(shellPath, timeout);

I'm sure you figured it out by now, but for completeness, it's supposed to be

return Shell.startCustomShell(shellPath, timeout);

instead of

return RootShell.getCustomShell(shellPath, timeout);

??
seems Shell also has no method named startCustomShell .

public static Shell startCustomShell(String shellPath) throws IOException, TimeoutException, RootDeniedException {

You might be using and older version?

RootShell/src/main/java/com/stericson/RootShell/execution/Shell.java
Line 908 in 48b5078
public static Shell startCustomShell(String shellPath) throws IOException, TimeoutException, RootDeniedException {
You might be using and older version?

oh, you are right,
sorry, I was mix up startCustomShell & getCustomShell.

Well don't close the issue, the error remains the same. RootShell.getCustomShell is not supposed to be recursive.