SteveKunG/FishOfThieves

Crash at during loading world with MineColonies

Closed this issue · 5 comments

Are you really sure that caused by this mod?
I see at com.minecolonies.coremod.colony.crafting.LootTableAnalyzer.toDrops(LootTableAnalyzer.java:58) ~[minecolonies-1.18.2-1.0.526-ALPHA.jar%23135!/:1.18.2-1.0.526-ALPHA] {re:classloading} in a crash report.

Its maybe incompatible with Minecolonies? I have reported to the devs too.

Minecolonies dev said: Fish of Thieves seems to be doing somethinkg funky with their loot tables. raise an issue on their github.

After testing I found the problem on my own LootTableLoadEvent, especially this line.
https://github.com/SteveKunG/FishOfThieves/blob/1.18.x_architectury/forge/src/main/java/com/stevekung/fishofthieves/forge/proxy/CommonProxyForge.java#L89

Not really sure why, I will find a way to fix this later.

Fixed in 1.0.4!