StevenBlack/hosts

hosts file has line with unexpected content

Closed this issue · 10 comments

alexsannikov commented

Hello,

I am using this repo as a source to build more "intellectual" filters lists for AdGuard Home.
I use some scripts to collapse the content and apply using regexp, as AdGuard Home supports it.

The following line which I found in "hosts" file (admalware) doesn't make sense and breaking my filters, leaving "www" only, which prohibit using any domain name starting from "www".

user@linux:/tmp $ cat hosts | grep "0.0.0.0 www "
0.0.0.0 www #.104.248.94.172
user@linux:/tmp $

welcome commented

Hello! Thank you for opening your first issue in this repo. It’s people like you who make these host files better!

StevenBlack commented

Thank you Alex @alexsannikov.

Ping Tomasz @FadeMind. These lines (lines 2028 to 2031) appear to be a problem....

StevenBlack commented

I'm wondering if we should actively filter lines like this. Thoughts?

0.0.0.0 104.248.94.172
0.0.0.0 142.93.134.136
0.0.0.0 159.65.193.7
0.0.0.0 167.99.34.247

Edit: this stackoverflow thread has an interesting and promising-looking regex.

Valid952HostnameRegex = "^(([a-zA-Z]|[a-zA-Z][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z]|[A-Za-z][A-Za-z0-9\-]*[A-Za-z0-9])$";
krystian3w commented

This are pages with fake flash player. Works on IP only.

hXXp://104[.]248[.]94.172/hello/e122xpy23v8upr2vrocw/?q=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpcCI6IjMxLjAuMTI2LjEwOCIsInJlZmVycmVyIjoiaHR0cDovL3dpc2RlbWVudGl2ZS5pbmZvL2JYM1lWWjBhUGIyY2hkMGVZZlhnUmhpaVBqVGtFbG1tY24wb2xwa3FQclRzTXQydU12endJeDJ5TnpqQVVCbUNlRG1FOUZ1R1pIVUlsSmtLUExUTU1OMk9NUHpRSVIyU05UalVVViIsInRzIjoxNTU4OTcyMjQ1LCJ1c2VyX2FnZW50IjoiTW96aWxsYS81LjAgKFdpbmRvd3MgTlQgMTAuMDsgV2luNjQ7IHg2NDsgcnY6NjcuMCkgR2Vja28vMjAxMDAxMDEgRmlyZWZveC82Ny4wIn0.7LqcBmibu_Pla0L1hb7-E-b3-R9iGs-SRr3Xp5GB8_k

this should down so I can remove 2 problematic rules.

IP may are pared with one server by https://github.com/emnh/homepage from Norway.

StevenBlack commented

Thanks @krystian3w. An IP address is NOT a valid host name.

See RFC 952. The status of RFC 952 is,

This RFC is the official specification of the format of the Internet Host Table.

krystian3w commented

OK added on uBo list names "directory" used for scam and problematic websites without host name gone from KAD HOSTS.

StevenBlack commented

Thank you @krystian3w!

StevenBlack commented

This is fixed in release 2.4.12.

Thank you, everybody.

Closing.

alexsannikov commented

Sorry guys, I've opened new Issue #1006 to point to the additional IP address in another list.
I am new on GitHub and thought comments are not available if ticket is closed already.
Thanks for understanding.

  • 👍1