Strajk/strava-enhancement-suite

Telemetry for debugging purposes

Strajk opened this issue · 2 comments

Hi, while checking the codebase, I've found a lot of features that are probably not needed anymore due to changes on Strava website.

But I'm a little worried about the word probably :)

Strava websites change a lot – both by developing new features, but also by various experiments/ab-testing/region-based new feature rollout/conditions for premium/non-premium users. So, it's very hard to test the extension thoroughly.

What do you think about adding telemetry for debugging/dev purposes?
Definitely anonymous, available as an option, and off by default.


Very basic example use case

  • There's hide_upcoming feature
  • I'm 99%, maybe 90%, maybe 85%, sure that it's not needed anymore
  • But, before removing it, I would like to check if it's really not used
  • We would add telemetry to it
  • If there would be no data about it for a – let's say – month, then we can remove it
// Before removing upcoming-events feature
$.option('meta:telemetry', function() {
  if ($('.sidebar .section#upcoming-events').length) {
    LOG('Upcoming events element found')
  }
});

What do you think about this? @lamby
I'm not sure about specific implementation details right now, wanna discuss it before thinking about it further.

lamby commented

Hm, good idea but on careful reflection, I think this might be overdoing things — I don't really want to watch/maintain telemetry data to work around Strava even more, if you know what I mean.

@lamby after some time to think about it more, I agree. Let's keep it simple for now.