Lack of check exist of acctAddress in mint module

[ThanhNhann]

Background

SetupNewModuleAccount function doesn't have a check if the acctAddress is exist

stride/x/mint/keeper/keeper.go

Lines 233 to 242 in 94e3a91

	func (k Keeper) SetupNewModuleAccount(ctx sdk.Context, submoduleName string, submoduleNamespace string) {
	// create and save the module account to the account keeper
	acctAddress := k.GetSubmoduleAddress(submoduleName, submoduleNamespace)
	acc := k.accountKeeper.NewAccount(
	ctx,
	authtypes.NewModuleAccount(
	authtypes.NewBaseAccountWithAddress(acctAddress),
	acctAddress.String(),
	),
	)

so in some cases, we can face some problems with this, I have run simulation for this and face it

Suggested Design

• Add a check if the acctAddress is exist

Acceptance Criteria

• Check for existing of acctAddress was added
• All test pass

[riley-stride]

Can you elaborate on

so in some cases, we can face some problems with this, I have run simulation for this and face it

I don't understand what will break in this case?

Also, if you are running simulation tests, could you share your code for that? We'd like to start using them.

[ThanhNhann]

Sure @riley-stride, I coding simulation test for Strid, and will update information of fail soon in the pr of this issue