Image push is not working
chriz2600 opened this issue · 7 comments
When you use "Push after successful build?" the build fails, because image.push is not invoked correctly in lib/push.js.
The image.push function from dockerode has the following signature:
Image.prototype.push = function(opts, callback, auth) {...}
In lib/push.js image.push(function() {...}) is used, which leads to an error, when Image.push tries to invoke the callback. I added an empty object as first parameter to image.push, which works for me now.
Interesting, seems like that API changed (author doesn't follow semver). Think you could submit a PR?
API (for Image.push) did not change since initial release v0.2.5.
Weird. It worked before..
Seems like apocas/dockerode@11d196a is the culprit. But yes, it looks to be used incorrectly.
@chriz2600 can you give master a try?
This is exactly the change i made locally. Works! Thank you!
Ok, I'll release a new version.