StrikerRockers-Mods/VanillaTweaks

[BUG] Siphon enchantment duplicates items when added to inventory

Opened this issue · 3 comments

Describe the bug
When using the Siphon enchantment on a Pickaxe any item I break is duplicated. I believe this has been happening for multiple versions, but I chalked it up to weirdness and generally didn't use the enchantment. This happens with anything I break, e.g. Waystones, Stone, Enchantment Tables, Grindstones, etc. I have not tried the enchantment with other tools.

To Reproduce
Steps to reproduce the behavior:

  1. Find or enchant a pickaxe with Siphon
  2. Break a block/item that breaks with a pickaxe
  3. Check inventory for the block
  4. Block/item is duplicated

Expected behavior
Break a block with a pickaxe enchanted with Siphon and receive one of that block only.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

  • Forge/Fabric Loader Version: Forge 43.2.2
  • MC Version: 1.19.2
  • Mod Version: 1.19.2-1.5.66
  • JEI Version (if present) : 11.6.0.1018
  • Fabric API Version (if present) :

Log output/error (via. Hastebin)
Get your minecraft log and paste it in the above link and paste the link here.

Additional context
Add any other context about the problem here.

Can you try the below steps to find any incompatability as VanillaTweaks alone works fine

Binary Searching
The binary search is a way of finding a faulty thing among a lot of other things, without having to remove the things one-by-one.

This is useful for finding a broken mod among hundreds of mods, without having to spend time testing the mods one-by-one.

The procedure is simple:
Remove half of the existing things, and put them aside.
Run the program / game.
Does the issue still exist?
If YES: Repeat from step 1 with the current things.
IF NO: Swap out the current things with the ones set aside, and repeat from step 1.
Repeat this process until the problematic thing/s have been found.

Thanks for the suggestion! I figured out it's the Proficiency: Honest Work (Levels) mod. The hilarious part is they haven't made a 1.19.2 update since 6/25/2023, which I believe is the same as VanillaTweaks! :)

I'm cool with not using it since I love VT and have been using it for a while now. Thanks for the quick response on this!

Same issue with Fireruby tools from BetterNether. Probably related to Rubys' Fire enchantment native and exclusive to those tools.

Versions (please complete the following information):

Fabric Loader Version: 0.15.11
MC Version: 1.20.1
Better Nether Version: 9.0.10
VanillaTweaks Version: 1.5.71
EMI Version (if present): 1.1.10
Fabric API Version (if present): 0.92.2+1.20.1