StudioCherno/Coral

Coral.Manage build warnings

pohlmf opened this issue · 2 comments

pohlmf commented

Branch: dev
Commit: 9f071d7

When building Coral.Managed within my project, some build warnings are given (mainly about null references) that should be handled e.g. by error reporting, establishing default handling, etc.

Used tools:

  • cmake 3.25.1
  • Visual Studio Community 2022 64-bit (17.9.2)

BuildWarningsCoralManaged.txt

VagueLobster commented

You do know that Warnings != errors, right?
I don't see a problem here as long as Coral builds.

pohlmf commented

Yes, I know that warnings != errors :)
(with decades of experience as sw-dev and sw-arch in automotive and consumer-electronics industry and with hobby-projects)

Why I reported the warnings:

  • It is good practice to avoid build errors and warnings wherever possible (avoid future issues; think through your code once more; keep overview of errors/warnings in large projects)
  • Each build-warning may hint to a potential future runtime bug (here clearly the case at least for some null-reference warnings.
  • First level of defense; we even didn't start talking about static-code-analysis

Just wanted to help the project.
Whether or not the warnings will be fixed is actually your decision.
My recommendation would be to fix them.

Anyway, thanks for considering the report.

  • 👍3