StylishThemes/GitHub-Dark

Support for addon Github Awesome Autocomplete

Closed this issue · 5 comments

sylveon commented

Feature Request

Add support of the addon Github Awesome Autocomplete.

Doesn't look great currently:
picture

Cross-post from here

redox commented

I'll submit a PR 👍

  • ❤️1
silverwind commented

Make sure it follows the general color scheme. e.g. #181818 background, #343434 and #484848 borders, #c0c0c0 bright text, #808080 faded text. Also, make it it's own section in the style, like we do for ZenHub, for example.

Mottie commented

Actually, if there is a way to use the same, or similar, class names that GitHub uses, you won't have to do much.

For example, we have a definitions already targeting GitHub's navigation menus (click on the "watch" or "unwatch" button to see the dropdown); these are their settings:

.select-menu-modal {
  background: #1b1b1b;
  color: #a0a0a0;
  border: #343434;
}
.select-menu-item {
  border-color: #484848;
}
.select-menu-item.selected, .select-menu-item.navigation-focus {
  background: $user_selected_color;
  color: #e0e0e0;
}

Update: hmm, ok maybe the .select-menu-item.selected doesn't include the user color background... Do we need to fix that @silverwind? LOL

silverwind commented

.select-menu-item.selected doesn't include the user color background... Do we need to fix that @silverwind? LOL

I see Github did some changes there, notably .navigation-focus is now a shade of grey, which we still have in the user color. .selected being green seems fine to me. I'll get to that later today.

Mottie commented

Thanks, I appreciate the help! :_happy:

  • 👍1