Style no longer works properly
Vulgaris-Viridis opened this issue · 17 comments
Hi there the-j0k3r,
Due to the recent quora changes style no longer works properly on the home page and the menu is too dark to be usable. (pic related)
FF 72.0.1 (64-bit) / 1903
@Vulgaris-Viridis please share a link to the offending page, I cant see anything out of the ordinary say at https://www.quora.com/ this is how it looks
Im on Windows 10 pro 1803 with same Firefox version as you.
@Vulgaris-Viridis I just release v2.0.0 click here to force upgrade
I added some fixes and a coulpe of usercss features that arent backwards compatible.
I still cant duplicate your issue, but if when you upgrade, let me know if it fixes the issue you reported or not.
If not please post links to page.
Hi @the-j0k3r, thanks for your prompt response!
Here's what I'm getting now:
And this is with css disabled:
Exactly identical situation with Chromium v.79.0.3945.88 as well.
@Vulgaris-Viridis please provide a link to that page!
I can tell you that in my setup the menu has no issues in any page nor can I duplicate the lack of post images, but the lack of images on your instance is weird to say the least.
Have you by chance upgraded Windows to 1903 from an earlier version?
💡 You may want to reinstall Stylus as well and this style from scratch.
Hi @the-j0k3r, It's just the homepage, i thought that was clear from the screenshots i posted.
Have you by chance upgraded Windows to 1903 from an earlier version?
I didn't but i did install the "enablement package" update that gives 1909 features to the 1903 version, but i didn't see anything in it that could potentially affect this. I've just reinstalled the Stylus and i got the same results.
Hi @the-j0k3r, It's just the homepage, i thought that was clear from the screenshots i posted.
Its not immediately obvious because I cant duplicate any of what you see
thats is https://www.quora.com/ right now 9.14AM
I didn't but i did install the "enablement package" update that gives 1909 features to the 1903 version, but i didn't see anything in it that could potentially affect this. I've just reinstalled the Stylus and i got the same results.
It could be the Upgrade borked something, it wouldn't be the first time I saw all manners of things affected by 1903 upgrades.
This is why I suggested you reinstall Stylus https://github.com/StylishThemes/Quora-Dark#installation and then
Reinstall the style.
Failing that I cant duplicate this at all.
Its not immediately obvious because I cant duplicate any of what you see
Well the feed will certainly be different but the page elements themselves can only look like that on the home page, any other tab will have uniquely different elements, is what i meant, but it certainly isn't that important.
If you can't replicate the issue, then naturally there is little you can do about it, it is probably something on my end, though i tried everything other than fresh FF install, which i might try in the future.
I will be closing the issue then, no point in keeping it open. Thank you once again for taking time to look into this.
You can try with a fresh Firefox profile. Let me know what happens.
@Mottie for feedback
Feedback
Nice =)
hi @the-j0k3r / @Mottie
You can try with a fresh Firefox profile.
Same. As i mentioned earlier, I'm getting the same results with chromium and no difference when all other extensions are disabled as well. I first suspected that it might be uMatrix/uBlock or another extension that's blocking it but other themes work fine and elements are properly displayed when style is off.
It is clearly something in this style that's not compatible with my "setup" but at this point it isn't really worth investigating further since i don't use quora lately that often anyways and as i can see you have much more important projects going on there as well.
If you however choose to investigate it further Quora - Dark focused mode applies the css properly to the feed column on the left but it doesn't style properly other elements, while
Simple Dark Quora is another style that just blocks images. So maybe that offers some clue..
Quora - Dark focused mode
Simple Dark Quora
Once again, thanks for your time. Cheers!
Funny.
Simple Dark Quora is another style that just blocks images
On your screenshots the images are missing, interesting!!
Quora - Dark focused mode applies the css properly to the feed column on the left but it doesn't style properly other elements
Your screenshots are also showing some elements not styled properly.
I'm getting the same results with chromium and no difference when all other extensions are disabled as well
This is odd, it could be your other Quora styles are still being loaded somehow and thus causing the breakages you see since all the issues you see are not being duplicated here.
Make sure you dont have any OPEN styles in Stylus editor when youre testing.
I first suspected that it might be uMatrix/uBlock or another extension that's blocking it but other themes work fine and elements are properly displayed when style is off.
This could very well be true in your setup, its not true on mine and without 3rd party confirmation for your issue theres nothing I can do.
What 'Ill do is reopen this issue and put out a req for duplication from anyone else.
I would suggest you actually remove these other styles and be sure I dont use ublock matrix (I do use origin) and no issues as Ive show on my screenshots.
I also cant dupe with Firefox, Google Chrome nor Opera in Windows 10 pro 1809 build 17763.973
@Vulgaris-Viridis ping
Hows this going? Still issues there?
I can confirm that the style is broken. There isn't much we can do about it though... I mean look at the classes we have to work with now
Even if we do the work to fix the style, there's no guarantee that the generated class names won't change every time they re-build their stylesheet.
Please try with 2.0.2 tested in Firefox, Goggle Chrome working as above screenshot
That fixed it for me. Thanks @the-j0k3r. I'll close the issue, if @Mottie still has issues you can reopen it. Cheers!
