Superbalist/laravel-ajax-redirector

Larval 5.6 Issues

matthewscalf opened this issue · 2 comments

matthewscalf commented

Getting this after upgrading Laravel:

Symfony\Component\Debug\Exception\FatalErrorException: Declaration of Superbalist\AjaxRedirector\AjaxRedirectResponse::isRedirect($location = NULL) must be compatible with Symfony\Component\HttpFoundation\Response::isRedirect(?string $location = NULL): bool
File "vendor/superbalist/laravel-ajax-redirector/src/AjaxRedirectResponse.php

Any chance of providing an update?

etiennemarais commented

Laravel started supporting PHP return types from 5.5.x (source) by using PHP 7.x.

Version branch 2.0.0 of this library seems to support older versions of PHP so it feels like we have to make a PR to bring in support for PHP return types.

We could make a v3.0.x branch/tag where we add support for Laravel versions upwards and including 5.5 (see source link ^^)

If you don't mind making a pull request, I will spend some time making the releases etc. That sound okay @matthewscalf ?