Superschnizel/obisdian-fast-text-color

[Bug] Inconsistent Color Entry Cycle State Tooltips

Closed this issue · 0 comments

Version
1.0.73

Describe the bug
Tooltips of the theme editor bold/italics/line/caps cycle state widget aren't following a consistent scheme.
The bold and italic buttons have the tooltips "Bold" and "Italic", regardless of their boolean state.
The (under-/over-/through-)line button cycles between the tooltips "none", "underline", "overline" and "line-through".
The capitalization button cycles between "normal", "all_caps" and "small_caps".

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Fast Text Color" community plugin settings
  2. Hover over any of the buttons of the formatting cycler
  3. Observe the inconsistent tooltips

Expected behavior
There are three consistent ways of phrasing these tooltips:

  1. Always display the general name of the formatting option, regardless of the state, i.e. "Bold", "Italics", "Lining", "Capitalization"
  2. Display the current state of each formatting option, i.e. "Normal"/"Bold", "Normal"/"Italics", "Normal"/"Underline"/"Overline"/"Strikethrough", "Normal"/"All Caps"/"Small Caps"
  3. Display the next state of each formatting option, indicating what would happen when clicked (see previous example for phrasing)
    I personally consider the latter case to be the most clear option, as information about the current state is already present. However, it might be advisable to make the phrasing more verbose than suggested here in order to iron out any possible misunderstandings.