Superschnizel/obsidian-fast-text-color

[Feature Request] Color Inline Code along with Text

Opened this issue · 2 comments

rismark commented

Is your feature request related to a problem? Please describe.

Inline code coloring is not supported currently, this results in unparsed closing mark =~ when colored.

More details and a screenshot

As shown in the screenshot below, these two lines cause problem to parsing.

~={green}`green` code=~
~={magenta}**`Magenta`**=~

In live preview (screenshot 1 - left), they are rendered as follows without any coloring:

green code=~
Magenta=~

Note, I also find the behavior to be different under Reading Mode or embedding.

When using Reading Mode or block embedding (screenshot 1 - right), the rendering is different.
The closing mark is consumed and color texts accordingly (leaving inline code uncolored).

green code
Magenta

ftc-1 1 1-inline-code-issue
Screenshot 1: v1.1.1 Inline Code Rendering Issue
(Left: Live Preview, Right: Block Embedding)


The code snippet I used is as follows: 

~={red}Red ==[[Welcome]] (internal link)===~
~={green}`green` code=~
~={blue}Blue
 => newline=~
~={cyan}Cyan [[Welcome]] (internal link)=~
~={magenta}**`Magenta`**=~
~={purple}Purple=~
~={yellow}Yellow=~
~={black}Black=~
~={invalid}Invalid Color=~
No-Color

Describe the solution you'd like

Expect to color inline code along with normal text, without unparsed closing mark.

Mockups

Here is a mockup screenshot (screenshot 2) of expected inline code coloring.
The green and magenta lines have their code and text colored.

expect-inline-code-coloring
Screenshot 2: Expect Inline Code Colored along with Text
(Left: Live Preview, Right: Source)


Expect inline code coloring for embedding as well.

expect-inline-code-coloring-embedding
Screenshot 3: Expect Inline Code Colored in Block Embedding

Additional context

Version Info
Obsidian: Version 1.6.7 (Installer 1.6.7)
Fast Text Color: Version 1.1.1 (Installed through https://obsidian.md/plugins?id=fast-text-color)

rismark commented

I just noticed #3 considered coloring inline codes as a bug.

However, this would be helpful depend on personal preferences.
Is it possible to make it a settings toggle?

Also, I think the unparsed closing mark =~ is still an issue.

mizu-048 commented

i suppose this also includes coloring for latex?