Suwayomi/Suwayomi-JUI

[Bug] Color picker not functioning as intended (visually for the most part)

Closed this issue · 6 comments

Steps to reproduce

  1. Choosing primary or secondary from Appearance menu.

Expected behavior

  1. The tickmark should change to different option when clicked.
    image

Actual behavior

  1. Both the sections in the above window stay the same when clicked but works as intended in the background. The bottom section should include a tick mark as well.

  2. Right side of the custom color picker is not displaying properly. I think the selecting the element is glitched?
    Im guessing splitting the right side to elements to select from failed . Now, each element now displays the whole range of colors rather than small part of them to choose from.
    image

small update on the first issue here,
The tick does not change no matter what if the first click or color choosing happens in the above section. It only works perfectly once there is click in the bottom section but not until then.

Found the cause of the first issue, its fixed, second is more difficult since its Tachiyomi 1.x code

For the second, i rewrote from the code of yours. Though I changed the layouts partly for my needs, it functions properly as seen below.
image
I can share the code i wrote later once I clean it up a bit.

Awesome, thanks for the help 💯

Fixed by 6ca9335 and 95fb8d6
Thanks for the fix!

Fixed another bug that I found a while ago that relates to this in 03ef901