SwedbankPay/design.swedbankpay.com

Tag small has two font-size rules

stepandersen opened this issue · 2 comments

stepandersen commented

The design guide has two equal specificity rules for the small element.
image

Currently the .small, small rule counts, it counts just because the small rule is overwritten when the .small, small rule is read.

To Reproduce
Steps to reproduce the behavior:

  1. Add a small tag
  2. Inspect the tag

Possible fix
Remove the small rule. I do however believe the font-size property value should be percent based rather than rem based, or in other words, I believe small should consider it's inherited font-size.
Rem based <h1>Heading 1 <small>small</small></h1>
image

Percent based <h1>Heading 1 <small>small</small></h1>
image

eskilsen commented

@PhungNg @VikingTristan denne er vel goood nå?