SwedbankPay/design.swedbankpay.com

Favicon in design guide v5

Closed this issue · 3 comments

Is your feature request related to a problem? Please describe.

I've been bashing my head on a rather silly problem - favicons. Specifically we had something that downscaled an older logotype, and it used a library that TeamCity threw a fit about - the npm package sharp. God knows why. In the end, I bypassed the problem by copying the generated image from my local build to the image folder, and set the favicon directly.

Part of the frustration arose from a lack of readymade favicons to simply drop into the project. This is given some additional relevance by the logo having changed slightly in times since.

In fact, even the design guide itself uses an outdated logo now. Here's a comparison between what we use in consumer portal - which is definitely using the old one - against the design guide one.

image

Describe the solution you'd like

Under the logotype page we should have a favicon section with download links.

Describe alternatives you've considered

I've considered personally downloading the logotype and modifying it. However, this can quickly cause fragmentation across products as everyone uses slightly modified, or even unmodified versions of the logotype as a favicon. This seems counterproductive when the design guide could simply offer standardized logotypes for this usecase.

Additional context

Old logo
favicon-96

New logo
image

Context

Favicons are one of the most readily recognized aspects of websites. It appears on the tab in browsers, on bookmarks, etc. Therefore we should have a consistent standard for this to stay on brand. Additionally, having a detailed description of favicons will also help mitigate technical issues, such as what image size to host the icon at.

Correct favicons used by the Design Guide documentation was fixed in this pull request which is included in the next release.

However, documentation for its usage by other clients is not included.
Perhaps something to bring up with the designers, @PhungNg ?

According to slack conversations, favicons will be available for download, but not in the current release.

This issue is fixed on release/7.0.0