SwensenSoftware/unquote

Change how array type signatures are sprinted to match change in F# language

stephen-swensen opened this issue · 2 comments

stephen-swensen commented

Per fsharp/fslang-suggestions#635 instead of e.g. int[] we should sprint int array where applicable.

The implementation is found in the ExtraReflections.fs file, given by the sprintSig function. Among other uses, this is used by the Type.FSharpName extension method.

Deleted user commented

@stephen-swensen May be similar case with list<_> and option<_>, should be _ list and _ option?

> typeof<float list>.FSharpName;;
val it : string = "list<float>"

> typeof<float option>.FSharpName;;
val it : string = "option<float>"

https://github.com/SwensenSoftware/unquote/blob/master/test/UnquoteTests/FSharpNameTests.fs#L12

  • 👍1
Deleted user commented

@stephen-swensen jagged & multidimentional arrays, should also be changed to float array array ...?

> typeof<float array array>.FSharpName;;
val it : string = "float[][]"

> typeof<float[,,]>.FSharpName;;
val it : string = "float[,,]"
  • 👍1