Breaking change released in patch release

Question

Breaking change released in patch release

Closed this issue a year ago · 10 comments

The latest release 9.0.10 introduces a breaking change

With Xcode 15, and Swift 5.9, the @MainActor annotations are causing compiler errors as we're not also annotating our code to work within the Async/Await ecosystem.

See this release

633b6e5

jarrodlombardo-EventBase commented a year ago

Thanks :D

Answer 1 · 2024-01-19T21:55:37.000Z

There are technically a few breaking changes within this release.

Please release a 9.0.11 reverting these changes and re-release as 10.0.0

Answer 2 · 2024-01-19T22:11:54.000Z

Yep, that was a mistake. It didn't occur to me that this was a breaking change. However, I don't think I'm going to revert – I'm not going to avoid new technologies because a small subset of projects aren't adopting them.

Answer 3 · 2024-01-19T22:17:53.000Z

Oh, I misread. You want me to change the version number. Yeah, I'll probably do that.

Answer 4 · 2024-01-22T21:29:34.000Z

Please rename the tag ASAP since it's breaking people's apps ~now.

Answer 5 · 2024-01-22T21:59:26.000Z

There are technically a few breaking changes within this release.

@Mordil what else did you note as a breaking change? I'm contemplating re-releasing the as 9.0.10, but without @MainActor. So if you have other concerns, please share.

Answer 6 · 2024-01-22T22:03:25.000Z

There are technically a few breaking changes within this release.

@Mordil what else did you note as a breaking change? I'm contemplating re-releasing the as 9.0.10, but without @MainActor. So if you have other concerns, please share.

It's arguable this doesn't count, but I believe changing the minimum supported platform to iOS 13 is itself a breaking change, because people will stop receiving updates if they have iOS 12 or earlier as their minimum - which breaks expectations of patch releases.

Answer 7 · 2024-01-23T00:18:59.000Z

Yes, any increase to minimum iOS version is always a breaking change. My team was hitting an issue with @MainActor and also nonisolated breaking the builds in our apps.

Answer 8 · 2024-01-23T00:29:05.000Z

I'm keeping @MainActor, so I'll be moving to 10.0.0. However, while I agree that bumping the minimum target is technically a breaking change, practically, I would not bump the major version for that given how few people would be affected, it would not be worth the tradeoff.

Answer 9 · 2024-01-23T06:37:28.000Z

Then please document in your README that you’re not SemVer compliant so others may know