SwiftStudies/OysterKit

Bug? Pinned tokens could be adopted by their parents

Closed this issue · 0 comments

When a successful match results in no node OR transient for a HomogenousAST the children are hoisted to the parent. Is this behaviour correct?

Investigation should validate that

  • It is not at least a warning that a pinned node is also transient or resulted in no node being created by the constructor (perhaps a side effect of the complexity of this approach?)
  • That if there are pinned children we should not preserve the structure (I don't think so, unless the parent is also pinned)