How to add validation without making field required?

Question

How to add validation without making field required?

Opened this issue 8 years ago · 21 comments

It seems it's not possible to set a validation rule on a field without making it required. i.e. - Phone number should not be required but if something is entered, validate it

Answer 1 · 2017-06-29T14:41:29.000Z

Absolutely right, If the field is empty then it tries to validate the value. There should be a condition to check if the field does not contains RequiredRule then do not validate field with blank values.

Answer 2 · 2018-02-27T12:13:43.000Z

Yes this seems to be issue I have empty fields without RequiredRule throwing errors so I think now there is only possibility to check by type of errors?

Answer 3 · 2018-06-15T18:43:33.000Z

Hello @RajatJain4061
are you working on this fix?

Answer 4 · 2018-07-18T02:22:50.000Z

@RajatJain4061, I also need this fixed. Can you fix it?

Answer 5 · 2018-07-18T04:57:42.000Z

@josueruiz7 @felipe-azevedo I will fix this ASAP within next 2 days

Answer 6 · 2018-07-24T17:09:25.000Z

@RajatJain4061 any news on this?

Answer 7 · 2018-07-30T22:18:57.000Z

@RajatJain4061 hey, man. Sorry to bother again, but I really need this.

Answer 8 · 2018-08-09T17:08:56.000Z

@RajatJain4061 any news? thanks.

Answer 9 · 2018-08-17T14:38:35.000Z

You can fix that by checking value is empty (return true) in the validate func in RegexRule

Answer 10 · 2018-08-17T16:40:40.000Z

@phuongnguyen2359 I expected the framework to do this. I have too many fields and I don't want to check each one for a value before validating.
@RajatJain4061 what happened to the fix? I need this, man. Thanks.

Answer 11 · 2018-08-17T16:48:03.000Z

@phuongnguyen2359 Also, this affects every Rule, not just Regex.
For example if I have minLength and maxLength validations and the field is not required, empty would be an acceptable value, but it's not because it will violate the minLength.

Answer 12 · 2018-08-17T16:50:41.000Z

Hopefully I’ll fix this on this Sunday. Sorry for getting delayed.

On Fri, 17 Aug 2018 at 10:18 PM, felipe-azevedo ***@***.***> wrote: @phuongnguyen2359 <https://github.com/phuongnguyen2359> Also, this affects every Rule, not just Regex. For example if I have minLength and maxLength validations and the field is not required, empty would be an acceptable value, but it's not because it will violate the minLength. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#185 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJ23SakywkYOBP_WuLCLbp_ptt5fVtPJks5uRvPEgaJpZM4OBRxO> .

--

Answer 13 · 2018-08-17T17:06:26.000Z

Thanks, @RajatJain4061
If you want a suggestion, I'd add a property to the Validator's init to allow empty for non-required fields. If that's set to true, when you validate a field that's not required and it's empty, all validations should return true, i.e. all rules should be ignored.

Answer 14 · 2018-08-17T17:09:37.000Z

If you think it will work then you can make the necessary changes and create a pull request. If everything goes well then I’ll merge your PR.

On Fri, 17 Aug 2018 at 10:36 PM, felipe-azevedo ***@***.***> wrote: Thanks, @RajatJain4061 <https://github.com/RajatJain4061> If you want a suggestion, I'd add a property to the Validator's init to allow empty for non-required fields. If that's set to true, when you validate a field that's not required and it's empty, all validations should return true, i.e. all rules should be ignored. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#185 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJ23SRsEMLu4XZTlroVYO2Za9IToFQggks5uRvgTgaJpZM4OBRxO> .

-- Thanks and Regards,

Answer 15 · 2018-08-17T17:15:51.000Z

@felipe-azevedo if the framework do this. it's cool still wait for it. In my case, I just need email field can be empty so doing this just affects email rule

Answer 16 · 2018-08-17T17:34:58.000Z

@phuongnguyen2359 I have big forms, 15, 20 fields all with validations. Most of the fields are required, but some are not, and to avoid having to create an exception for each of the affected rules, I wanted to fix this across the board.
@RajatJain4061 this was my suggestion for you to fix it, man. I don't have time to fix it.

Answer 17 · 2018-08-17T17:36:12.000Z

Ok I’ll try to do it myself

On Fri, 17 Aug 2018 at 11:04 PM, felipe-azevedo ***@***.***> wrote: @phuongnguyen2359 <https://github.com/phuongnguyen2359> I have big forms, 15, 20 fields all with validations. Most of the fields are required, but some are not, and to avoid having to create an exception for each of the affected rules, I wanted to fix this across the board. @RajatJain4061 <https://github.com/RajatJain4061> this was my suggestion for you to fix it, man. I don't have time to fix it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#185 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJ23Sf_P09osn02P7fATO900phd4oj8gks5uRv7DgaJpZM4OBRxO> .

-- Thanks and Regards, *Rajat Jain* *(Software Engineer - iOS & PHP)* Mob:8104614061 LinkedIn : https://www.linkedin.com/in/rajat-jain-945317ab Skype Id: rajatjain4061

Answer 18 · 2018-08-28T17:41:34.000Z

@RajatJain4061 hi, any news on this?
Thanks.

Answer 19 · 2018-09-04T20:17:54.000Z

@RajatJain4061 can you fix this please?

Answer 20 · 2018-10-31T18:03:31.000Z

@RajatJain4061, @davepatterson
is this issue ever going to be fixed?
This is an important issue and I'd really appreciate if it was fixed.
It's been open for a very long time.
Thank you.

Answer 21 · 2018-11-05T15:52:44.000Z

Any news for this issue? I also need the fix.

Thanks.