Typescript strict mode supported?

Question

Typescript strict mode supported?

jvanbruegge opened this issue 8 years ago · 16 comments

I haven't tried it, but I don't think this works with typescript's --strict flag, because of missing JSX namespace declarations

Answer 1 · 2017-05-12T15:53:09.000Z

I dont really know typescript. I found the '--jsxFactory' to add the createElement pragma.

Snabbdom-pragma, is transpiler independant, and transform createElement call to Snabbdom vnode.

Answer 2 · 2017-05-12T16:06:05.000Z

Ow. I guess I misunderstood you. Are you talking about the lack of Typescript type definitions in Snabbdom-pragma ?

Answer 3 · 2017-05-12T16:08:42.000Z

Yes, typescript expects a global JSX namespace declaration.

Answer 4 · 2017-05-12T16:09:31.000Z

More info here: cyclejs-community/create-cycle-app-flavors#21

Answer 5 · 2017-05-12T16:25:13.000Z

So, to solve this issue I need to write a Typescript declaration file ? Both for JSX and Snabbdom Vnode ? https://www.typescriptlang.org/docs/handbook/jsx.html

Answer 6 · 2017-05-12T16:30:32.000Z

Snabbdom provides a declaration for VNode, but it seems we need something like this: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/df09b2a3368b7f47959f86247a12ab95b9d261f4/types/react/index.d.ts#L2721

But instead of React.ReactElement with VNode

Answer 7 · 2017-05-12T16:33:48.000Z

Thank you. I will take a look. This is a great trigger to start to learn Typescript ! Can I refer to the Snabbdom Vnode declaration from Snabbdom-pragma one ?

Answer 8 · 2017-05-12T16:35:30.000Z

import { VNode } from 'snabbdom';
yes

Answer 9 · 2017-05-12T19:44:12.000Z

Live on : feature/definitely-typed

This is a pretty naive implementation but seem to fill all the needs.
Give it a try, and feel free to contribute.

Answer 10 · 2017-05-15T12:57:48.000Z

@jvanbruegge Did you take an eye on it ? This is what you need ?

Answer 11 · 2017-05-15T13:06:59.000Z

I think it is, but can you publish it as alpha release, then I can test properly

Answer 12 · 2017-05-15T13:14:24.000Z

Couldn't you npm install it from branch ?

Swizz/Snabbdom-pragam#feature/definitely-typed

Answer 13 · 2017-05-15T13:54:29.000Z

Yeah, that worked.
You don't get errors with this, sadly you have to put a /// <reference> in your code to make it work, but only in the index file, so that's not too bad

Answer 14 · 2017-05-15T14:01:29.000Z

I will dive into Typescript someday soon, I promise.

As this change is not really a breaking one, I can release it at your go.

Answer 15 · 2017-05-15T14:02:04.000Z

yeah, go for it
we can improve the typings in the future

Answer 16 · 2017-05-15T14:19:00.000Z

Npm published : v2.2.0