SyliusCrafts/BootstrapTheme

Not compatible with 1.9

aleho opened this issue · 4 comments

aleho commented

This theme loads in Sylius 1.9, but as soon as a child theme wants to extend it, it isn't loaded any more at all.

Reverting back to legacy theme bundle mode seems to "fix" this issue:

sylius_theme:
    legacy_mode: true

Would have been nice to at least find a notice here or even an upgrade (release??) to know what's going on.

oallain commented

Hello @aleho ,

Feel free to propose a PR, it will help many users, I think.

Regards

aleho commented

@oallain What is your affiliation with this official Sylius theme and how does your single contribution to this repository in 2019 warrant a passive aggressive tone against a Sylius Plus customer who, after being presented with upgrade notices in various places (admin backend, official website, docs) had to overcome quite a few obstacles to get 1.9 running despite no warnings at all but quite a few incompatibilities of official components?

May I sincerely request you not to scold people for not providing a PR when they're taking time and effort to document shortcomings that might benefit others presented with the same challenges and looking for a solution?

  • 👍1
oallain commented

Hello @aleho ,

I have no particular affiliation, I'm just a user of this Theme.

I'm so sorry if you found my tone aggressive, it wasn't. My post was a suggestion, because if you've done the research / fix work already, it will help people in the future I think.

Bests,

aleho commented

@oallain In hindsight I have to apologize for reading your comment as aggressive instead of assuming best intentions. I've read numerous "feel free to X" comments in the past which mostly were meant to come across with a scolding tone. Sorry for that.

As for the PR: I really don't know where the Sylius team is going with their deprecations or this theme or what my "fix" (which is a workaround prone to break in the very near future) might actually cause.