Generate sane default values
Closed this issue · 2 comments
duck2 commented
I don't think our structs are zeroing out properly. Inspect and fix this.
Furthermore, default values are used in some optional attributes. It would be good to address this.
mithro commented
For the structures to be "Plain Old Data" types, they need to have default values of zero.
duck2 commented
I think they already have constructors&destructors due to having unique_ptr
, vector
and string
s in them, though.
In fact, it takes considerable time to free the structures. I think this is due to the great number of std::strings.