SymbolixAU/jsonify

consolodate with RcppSimdJson

dcooley opened this issue · 5 comments

dcooley commented

Given RcppSimdJson:::..deserialize_json() can replicate the behaviour of jsonify::from_json(), should I include RcppSimdJson as a LinkingTo, and use it if the end-user's hardware is up to it?

A wider question for @eddelbuettel & @knapply :

Do you think it's worth consolodating these libraries into one R package, which will automatically call either the simdjson or rapidjson .h code depending on the user's hardware?

Then there will only be one package which does both the from_json() and to_json()

eddelbuettel commented

Good questions. I don't know. Good thing is I think we're not in a rush.

  • 👍1
knapply commented

Can LinkingTos be optional like Suggests?

As things currently stand, that would eliminate jsonify as an option for Windows and those lacking C++17 compilers.

eddelbuettel commented

Can LinkingTos be optional like Suggests?

No. Only Suggests: has optionality :-/

JosiahParry commented

It would be nice. I'm presently using both in a package I'm developing :)

eddelbuettel commented

I actually implemented a 'conditional' LinkingTo: once in a package in configure logic. If the (otherwise) Suggests:-only package is present, add a -I.... to the preprocessor/compiler flags. Easy enough and reliable.