Should not include trailing slashes when sending URI prefix / instance URL
Closed this issue · 5 comments
cjmyers commented
Should not have trailing slashes. These should either be trimmed before being sent to WoR or trimmed upon receipt.
3ach commented
Okay, this is more clear. This should be on this side. I will clear it off the SBH issue tracker.
cjmyers commented
Well, it should be SBH I think, since what it sends to register should not have trailing slashes.
… On Jul 26, 2017, at 3:50 PM, Zach Zundel ***@***.***> wrote:
Okay, this is more clear. This should be on this side. I will clear it off the SBH issue tracker.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADWD985bTibUwm3Zhzi2DVo3IDW0TqZaks5sR1I9gaJpZM4OcFbx>.
3ach commented
You can do it either place, but I would prefer to do it here because SynBioHub is not the only way to send WoR join requests, you can also do it through the API. Makes more sense to enforce the invariant on this end.
cjmyers commented
I think WoR should actually throw an error if the format is incorrect for the URL. SBH should always make a proper request.
… On Jul 26, 2017, at 3:57 PM, Zach Zundel ***@***.***> wrote:
You can do it either place, but I would prefer to do it here because SynBioHub is not the only way to send WoR join requests, you can also do it through the API. Makes more sense to enforce the invariant on this end.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADWD98aPaLGEaI2ADyv5XA_HKJbVZ9TQks5sR1PsgaJpZM4OcFbx>.
3ach commented
But that's not an incorrect URL, it's a quirk with SynBioHub, right?