No info dialog for IE users

Question

No info dialog for IE users

Opened this issue 5 years ago · 11 comments

Describe the bug:
If people open the phonebook in IE they will don't see anything.

Console:

To Reproduce:
Open demo-phonebook.me.

Expected behavior:
There should be an info that IE is not supported.
The dialog exists but don't show.

--> There is an option in IE where you can easy open the site in edge (
STRG+Shift+E). A button to open the site in another browser would be cool.

Additional context:
IE 11.864.17763.0

Answer 1 · 2019-12-19T09:33:57.000Z

Possible solution: Display the dialog before using UrlSearchParams, or conditionally check if IE is used before accessing it.

Answer 2 · 2020-01-10T15:11:52.000Z

We should display this dialog without the need to load angular, thus we can drop everything that we currently need to be compliant with IE.

Answer 3 · 2020-01-21T11:05:00.000Z

@DanielHabenicht so I will put clean JS code in an extra file, wich will be loaded before angular?

Answer 4 · 2020-01-21T11:11:57.000Z

Well you can also use the statement HTML feature of IE

https://docs.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/compatibility/ms537512(v=vs.85)?redirectedfrom=MSDN

And add it to the index.html

Answer 5 · 2020-01-21T11:30:26.000Z

I guess that wont work in "newer" Versions of IE: https://docs.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/compatibility/hh801214(v=vs.85)?redirectedfrom=MSDN

Answer 6 · 2020-01-21T16:55:40.000Z

Ok, dann einfach ein Javascript Snippet nutzen und am besten unten in der index.html anfügen.

Answer 7 · 2020-01-21T18:36:32.000Z

accidentally closed @DanielHabenicht ?

Answer 8 · 2020-01-21T18:41:28.000Z

Seems so, the new GitHub app does not have colored buttons.

Answer 9 · 2020-01-31T10:52:07.000Z

@FrankLambrette if you're implementing the feature maybe you can try to implement this, if it's easy..
"--> There is an option in IE where you can easy open the site in edge (
STRG+Shift+E). A button to open the site in another browser would be cool."

Answer 10 · 2020-03-04T08:48:28.000Z

@DanielHabenicht @mschwrdtnr , after two month no i have some time to implement it. Just a question: how do I import a plain js script in the index.html? Angular Docu says I should put it in the angular.json scripts section. But we need to load the script before angular is loaded. If I try to import it via <script> I allways get a 404. Any ideas?

Answer 11 · 2020-03-04T09:23:39.000Z

Just include it directly in the index.html.

In the end, it does not have to be something fancy. A simple timeout/detection mechanism would do it aswell.