Review comments ...
Apollon77 opened this issue · 0 comments
Apollon77 commented
- Please remove .vscode from GitHub
- using getStates (which gets state values) might not return all objects ... so maybe better use getObjects? https://github.com/TA2k/ioBroker.nina/blob/master/main.js#L40
- will https://github.com/TA2k/ioBroker.nina/blob/master/main.js#L42 do something at all? you use the states-object keys and iterate and delObject if the key is not in object states ?! Or do I miss something here?
- you might want to add error handling here for statuscode 200 and such :-) https://github.com/TA2k/ioBroker.nina/blob/master/main.js#L67
- setInterval ... personally don't like :-)) But you know why ... https://github.com/TA2k/ioBroker.nina/blob/master/main.js#L114
- please do not implement state7object change if not used
Thank you!