TASEmulators/BizHawk

There was an error importing the bkm Movie program

Opened this issue · 2 comments

EmuHawk Ver: 2.9.2 dev build
Windows 10 Version 10.0.19044

System.NullReferenceException: Object reference not set to an instance of an object.
   at BizHawk.Client.Common.movie.import.BkmImport.RunImport()
   at BizHawk.Client.Common.MovieImporter.Import(IDialogParent dialogParent, IMovieSession session, String path, Config config)
   at BizHawk.Client.Common.MovieImport.ImportFile(IDialogParent dialogParent, IMovieSession session, String path, Config config)
   at BizHawk.Client.EmuHawk.MainForm.ProcessMovieImport(String fn, Boolean start)
   at BizHawk.Client.EmuHawk.MainForm.ImportMovieMenuItem_Click(Object sender, EventArgs e)
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Can you copy the commit hash from Help > About...? And are you able to share the movie or link to where you found it?

Yeah bkm importing is completely broken currently...

To elaborate slightly: The bkm importing process relies on the currently loaded core to import the movie, or well, it did before that functionality was removed from the movie importer.

I would argue that relying on the currently loaded core was incorrect behavior to begin with, and the correct move would be to fix the importer to either query for the core or select an appropriate one automatically.